Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use :insecure option by default in Patron #691

Merged
merged 4 commits into from
May 11, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Do not use :insecure option by default in Patron
The session.insecure option is set to true by default. This disables
the ssl verification of the host and, according to the Patron
documentation, one should "think twice before using this option".

See also
http://www.rubydoc.info/gems/patron/0.8.0/Patron%2FSession%3Ainsecure
stayhero committed May 9, 2017

Verified

This commit was signed with the committer’s verified signature.
oliviertassinari Olivier Tassinari
commit c09ead86fd3a80bcea6d098112f903b8a61f53d1
1 change: 0 additions & 1 deletion lib/faraday/adapter/patron.rb
Original file line number Diff line number Diff line change
@@ -67,7 +67,6 @@ def call(env)

def create_session
session = ::Patron::Session.new
session.insecure = true
@config_block.call(session) if @config_block
session
end