Change a console.warn to console.error for reporting bad rule inserti…

…on attempt in speedy mode (emotion-js#1811)
louisgv · Mar 16, 2020 · 3d38b09 · 3d38b09
1 parent 116b617
commit 3d38b09
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/packages/css/test/sheet.dom.test.js b/packages/css/test/sheet.dom.test.js
@@ -31,7 +31,7 @@ describe('sheet', () => {
 
   test('throws', () => {
     sheet.speedy(true)
-    const spy = jest.spyOn(global.console, 'warn')
+    const spy = jest.spyOn(global.console, 'error')
     sheet.insert('.asdfasdf4###112121211{')
     expect(spy).toHaveBeenCalled()
   })

diff --git a/packages/sheet/__tests__/index.js b/packages/sheet/__tests__/index.js
@@ -62,16 +62,16 @@ describe('StyleSheet', () => {
 
   it('should throw when inserting a bad rule in speedy mode', () => {
     const sheet = new StyleSheet({ ...defaultOptions, speedy: true })
-    const oldConsoleWarn = console.warn
+    const oldConsoleError = console.error
     // $FlowFixMe
-    console.warn = jest.fn()
+    console.error = jest.fn()
     sheet.insert('.asdfasdf4###112121211{')
-    expect(console.warn).toHaveBeenCalledTimes(1)
-    expect((console.warn: any).mock.calls[0][0]).toBe(
+    expect(console.error).toHaveBeenCalledTimes(1)
+    expect((console.error: any).mock.calls[0][0]).toBe(
       'There was a problem inserting the following rule: ".asdfasdf4###112121211{"'
     )
     // $FlowFixMe
-    console.warn = oldConsoleWarn
+    console.error = oldConsoleError
     sheet.flush()
   })
 

diff --git a/packages/sheet/src/index.js b/packages/sheet/src/index.js
@@ -131,7 +131,7 @@ export class StyleSheet {
         )
       } catch (e) {
         if (process.env.NODE_ENV !== 'production') {
-          console.warn(
+          console.error(
             `There was a problem inserting the following rule: "${rule}"`,
             e
           )