Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dark mode checkbox #1225

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Conversation

Computroniks
Copy link
Contributor

The border colour of the checkbox has been changed to make it more
visible to the user when the dark mode is in use.

Signed-off-by: Computroniks [email protected]

Description

Previously, the check button with the label Remember me on the login page was near invisible for users using the dark mode due to the default bootstrap border colour being used. This PR fixes that issue by changing the border colour to $dark-border-color.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task) - Not required

Screenshots (if any)

Previous colour:
image
New colour:
image

src/assets/app.scss Outdated Show resolved Hide resolved
The border colour of the checkbox has been changed to make it more
visible to the user when the dark mode is in use.

Signed-off-by: Computroniks <[email protected]>
@Computroniks
Copy link
Contributor Author

Anything I can do to help get this merged?

@louislam louislam merged commit c0e0698 into louislam:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants