Fixed searching without setup leads to a sqlite error (#59)

loupe-php · Jan 18, 2024 · e3ea55a · e3ea55a
1 parent 522de62
commit e3ea55a
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 0 deletions.
diff --git a/src/Internal/Engine.php b/src/Internal/Engine.php
@@ -205,6 +205,10 @@ public function needsReindex(): bool
 
     public function search(SearchParameters $parameters): SearchResult
     {
+        if ($this->getIndexInfo()->needsSetup()) {
+            return SearchResult::createEmptyFromSearchParameters($parameters);
+        }
+
         return (new Searcher($this, $this->filterParser, $parameters))->fetchResult();
     }
 

diff --git a/src/SearchResult.php b/src/SearchResult.php
@@ -20,6 +20,19 @@ public function __construct(
     ) {
     }
 
+    public static function createEmptyFromSearchParameters(SearchParameters $searchParameters): self
+    {
+        return new self(
+            [],
+            $searchParameters->getQuery(),
+            0,
+            $searchParameters->getHitsPerPage(),
+            $searchParameters->getPage(),
+            0,
+            0
+        );
+    }
+
     /**
      * @return array<array<string, mixed>>
      */

diff --git a/tests/Functional/SearchTest.php b/tests/Functional/SearchTest.php
@@ -1532,6 +1532,21 @@ public function testTypoTolerance(TypoTolerance $typoTolerance, string $query, a
         $this->searchAndAssertResults($loupe, $searchParameters, $expectedResults);
     }
 
+    public function testWithoutSetup(): void
+    {
+        $loupe = $this->createLoupe(Configuration::create());
+        $searchParameters = SearchParameters::create()->withQuery('foobar');
+
+        $this->searchAndAssertResults($loupe, $searchParameters, [
+            'hits' => [],
+            'query' => 'foobar',
+            'hitsPerPage' => 20,
+            'page' => 1,
+            'totalPages' => 0,
+            'totalHits' => 0,
+        ]);
+    }
+
     public static function typoToleranceProvider(): \Generator
     {
         yield 'Test finds exact match when typo tolerance is disabled' => [