Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dyn workers #13

Closed
wants to merge 1 commit into from
Closed

dyn workers #13

wants to merge 1 commit into from

Conversation

szmglh
Copy link
Contributor

@szmglh szmglh commented Jul 19, 2024

  • create workers as needed

Copy link

@szmglh szmglh changed the base branch from main to pacer2 July 19, 2024 14:37
@eugenepaniot
Copy link
Contributor

hey @szmglh
jfyi, the latest prod build was - #8 (~1y ago) which contain quite a few optimisations, fixes, etc..
Feel free to close it if it is not necessary.

@szmglh
Copy link
Contributor Author

szmglh commented Jul 29, 2024

Closing, as it does not have significant impact compared to the constant number of worker version.

@szmglh szmglh closed this Jul 29, 2024
@szmglh szmglh deleted the dyn-workers branch July 29, 2024 08:34
@szmglh
Copy link
Contributor Author

szmglh commented Jul 29, 2024

hey @szmglh jfyi, the latest prod build was - #8 (~1y ago) which contain quite a few optimisations, fixes, etc.. Feel free to close it if it is not necessary.

Thanks @eugenepaniot , the problem turned out to be with the pacer algorithm. The optimisations you mention did make a difference, because they partially covered up the issue, but they have not fixed the root cause. With the new pacer algorithm we can easily hit the rate we're after for the foreseeable future. Once we hit CPU limit, we'll look into those. The PR you mention also contains features, like metrics server, which are likely to make it to main at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants