Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix #103: propagate error in Emitter.EmitSync #104

Merged
merged 1 commit into from
Mar 8, 2018
Merged

bugfix #103: propagate error in Emitter.EmitSync #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions emitter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,23 @@ func (e *Emitter) Emit(key string, msg interface{}) (*kafka.Promise, error) {

// EmitSync sends a message to passed topic and key
func (e *Emitter) EmitSync(key string, msg interface{}) error {
promise, err := e.Emit(key, msg)
var (
err error
promise *kafka.Promise
)
promise, err = e.Emit(key, msg)

if err != nil {
return err
}

done := make(chan struct{})
promise.Then(func(err error) {
promise.Then(func(asyncErr error) {
err = asyncErr
close(done)
})
<-done
return nil
return err
}

// Finish waits until the emitter is finished producing all pending messages
Expand Down