add restartable view support #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db7
force-pushed
the
feature/restartable-views
branch
from
d7293f2 to
8acf000
Compare
SamiHiltunen
previously approved these changes
Mar 13, 2018
sweigert
previously approved these changes
Mar 13, 2018
view.go
Outdated
| if v.terminated { | ||
| return fmt.Errorf("view: cannot reinitialize terminated view") | ||
| } | ||
| defer v.mInit.Unlock() |
There was a problem hiding this comment.
This defer should be above the conditional as it could return without unlocking
db7
force-pushed
the
feature/restartable-views
branch
from
ba7e365 to
ecdeedf
Compare
|
True, I just fixed it.
… On 14. Mar 2018, at 10:47, Sami Hiltunen ***@***.***> wrote:
@SamiHiltunen commented on this pull request.
In view.go <#105 (comment)>:
> @@ -110,6 +112,12 @@ func (v *View) createPartitions(brokers []string) (err error) {
// reinit (re)initializes the view and its partitions to connect to Kafka
func (v *View) reinit() error {
+ v.mInit.Lock()
+ if v.terminated {
+ return fmt.Errorf("view: cannot reinitialize terminated view")
+ }
+ defer v.mInit.Unlock()
This defer should be above the conditional
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#105 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZmJiF1QxFNv4sszmUdFSSInPwsFcSLks5teOdEgaJpZM4So2b9>.
|
SamiHiltunen
approved these changes
Mar 14, 2018
tsne
reviewed
Mar 14, 2018
| v.mInit.Lock() | ||
| if v.terminated { | ||
| return | ||
| v.mInit.Unlock() |
There was a problem hiding this comment.
This unlock is dead code and could result in a deadlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #102.
If one starts a view with the option
goka.WithViewRestartable(), the view may be restarted or used, eg, by callingGet()andRecovered(),Iterator(), etc. To release all resources, ie, close the underlying local storage, one must callStop()when using theRestartable()option.