examples #24
Merged
examples #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flosch
approved these changes
May 23, 2017
examples/2-clicks/README.md
Outdated
| ### Partitioning and Concurrency | ||
|
|
||
| Messages are partitioned in Kafka using the message key. Messages within each partition are processed sequentially, | ||
| but in parallel for all partitions. That means for our case, different users can be modified |
There was a problem hiding this comment.
This sounds a bit wonky, maybe something like Messages are processed sequentially inside a given partition but multiple partitions process messages concurrently.
examples/2-clicks/README.md
Outdated
|
|
||
| Messages are partitioned in Kafka using the message key. Messages within each partition are processed sequentially, | ||
| but in parallel for all partitions. That means for our case, different users can be modified | ||
| in parallel. A single user however is always modified sequentially, because all messages for that user are assigned |
There was a problem hiding this comment.
in parallel -> concurrently
examples/2-clicks/README.md
Outdated
| Messages are partitioned in Kafka using the message key. Messages within each partition are processed sequentially, | ||
| but in parallel for all partitions. That means for our case, different users can be modified | ||
| in parallel. A single user however is always modified sequentially, because all messages for that user are assigned | ||
| to the same partition which runs sequentially. |
There was a problem hiding this comment.
Perhaps we should add a small explanation here as to why the messages for the user are assigned to the same partition, ie. Since we are using the user id as the message's key...
SamiHiltunen
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.