Fix examples initialization after auto creation of topics is disabled #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ensure topic 'user-click' exists * view goroutine must wait for the processor to be initialized
* ensure topics exist * synchronize goroutines to be initialized before running * still has race conditions in initialization, but after a restart the example works
* added file topic.go
* ensure topic exists
* ensure topic exists
* in runProcessor we use joinGroup, which depends on its initialization in runJoinProcessor
…vent race conditions TopicManager.EnsureStreamExists is not atomic and therefore can fail if between checking if a topic exists and creating a new one the topic gets created by another Goroutine.
… in the code but was incorrect in the README
frairon
reviewed
Jun 9, 2022
frairon
added a commit
that referenced
this pull request
Jun 9, 2022
* Ensuring the existence of topics in the Run functions was not correctly preventing race conditions - only making them more unlikely to happen. Introduced a PrepareTopics function in every processor package, where topics are created if they do not exist before starting any Goroutine. * Removed synchronization with WaitGroup, this made the example too complex. With the PrepareTopics functions there is no need for this synchronization.
|
Fixed and simplified example 3
|
frairon
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the changes in commit 2ff0aea topics will not get automatically created, which breaks examples 2, 3, 5, 6, 7 and 8.
This is fixed in this PR by:
Also applied a small fix in README.md of example 3: e31d04d