New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use AsyncClose in simple consumer #67

Merged

db7 merged 2 commits into master from partition-consumer-async-close

Dec 11, 2017

Collaborator

db7 commented Dec 11, 2017

In the simple consumer we should use AsyncClose to close the PartitionConsumer since we are consuming from the errors channel.


          use AsyncClose in simple consumer

9bbf5d5

db7 requested review from SamiHiltunen and frairon

December 11, 2017 11:11


          use multierr inside simple consumer

e25c9fc

SamiHiltunen approved these changes

View reviewed changes

db7 merged commit 030dcfe into master

db7 deleted the partition-consumer-async-close branch

December 11, 2017 13:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet