Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Verilator dependency #2131

Closed
nasahlpa opened this issue Jan 18, 2024 · 0 comments · Fixed by #2133
Closed

Upgrade Verilator dependency #2131

nasahlpa opened this issue Jan 18, 2024 · 0 comments · Fixed by #2133

Comments

@nasahlpa
Copy link
Member

As discussed with @rswarbrick in PR #2129, it might be worth to upgrade the Verilator dependency. That reason is that we got some linting errors, i.e., IMPERFECTSCH, that were removed in more recent Verilator versions.

When upgrading Verilator, it might also be worth to get rid of the following hack to get rid of the linting error:

assign rst_shadow_set_single_bit = rst_shadow_set_q[0];

nasahlpa added a commit to nasahlpa/ibex that referenced this issue Jan 19, 2024
To be consistent between projects, this PR updates the Verilator
version to 4.210, which is also used by OpenTitan. The reason for
this change is that in lowRISC#2129 Verilator linting issues occured
that did not occur in OpenTitan.

Closes lowRISC#2131.

Signed-off-by: Pascal Nasahl <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Jan 19, 2024
To be consistent between projects, this PR updates the Verilator
version to 4.210, which is also used by OpenTitan. The reason for
this change is that in #2129 Verilator linting issues occured
that did not occur in OpenTitan.

Closes #2131.

Signed-off-by: Pascal Nasahl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant