Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spi_device] Check if CSb deasserted in the middle of byte transfer in Generic Mode #10058

Closed
eunchan opened this issue Jan 13, 2022 · 4 comments
Labels
Component:RTL Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:spi_device Priority:P3 Priority: low Type:Enhancement Feature requests, enhancements Type:FutureRelease Not relevant to currently planned releases/milestones

Comments

@eunchan
Copy link
Contributor

eunchan commented Jan 13, 2022

Current FwMode(GenericMode) ties fwm_rxerr to 0. The signal intended to catch the receiver error in FwMode, which is to catch the CSb de-assertion without completing the byte transfer.

I decided to icebox the feature and implement in next revisions (or removing Generic mode entirely).

This issue is to track the item.

Effort estimate by @hcallahan-lowrisc:

Note that there is a number of open issues about CSB behaviour and robustness to errors, so some estimated effort (if deemed necessary) may overlap between those issues. (#10058 #12747 #15517 #15721)

estimate 20
remaining 2023-03-23 20

@eunchan eunchan added Priority:P3 Priority: low Type:Enhancement Feature requests, enhancements Component:RTL labels Jan 13, 2022
@eunchan eunchan self-assigned this Jan 13, 2022
@andreaskurth
Copy link
Contributor

Triaged for spi_device. Assigning to M2.5 with Priority:P2 Priority: medium because even though this is about robustness in an environment with errors, we should check with the product team if the behavior of spi_device is acceptable. If yes, we can defer this to Type:FutureRelease Not relevant to currently planned releases/milestones .

@hcallahan-lowrisc
Copy link
Contributor

Note that there is a number of open issues about CSB behaviour and robustness to errors, so some estimated effort (if deemed necessary) may overlap between those issues. (#10058 #12747 #15517 #15721)

estimate 20
remaining 2023-03-23 20

@moidx
Copy link
Contributor

moidx commented Apr 5, 2023

We'll evaluate the behavior in silicon and determine if there are any changes needed. Adding FutureRelease for now.

@moidx moidx added Type:FutureRelease Not relevant to currently planned releases/milestones Priority:P3 Priority: low and removed Priority:P2 Priority: medium labels Apr 5, 2023
@msfschaffner msfschaffner added the Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones label Oct 6, 2023
@msfschaffner
Copy link
Contributor

Since we plan to deprecate generic mode, this will no longer be necessary.

CC @a-will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL Earlgrey-PROD Candidate Temporary label to triage issues into Earlgrey-PROD Milestones IP:spi_device Priority:P3 Priority: low Type:Enhancement Feature requests, enhancements Type:FutureRelease Not relevant to currently planned releases/milestones
Projects
None yet
Development

No branches or pull requests

5 participants