Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SYNC signal generation on SETUP and OUT DATA packets. Non-initial SYNC omitted the first K state and usbdev coped because it responds to the final 6 bits of the SYNC signal rather than requiring detection of the full 8 bits.*
Previous SYNC signal at start of DATA transaction/packet shows [J]KJKJKJKK at the position of the red marker:

Note that the first 'J' is transmitted but since the bus is already in the Idle/J state, there is no transition.
The invalid signal results from advancing the
bit
number even when transitioning from ST_EOP to S_SYNCThe above signals show three distinct packets, separated by the driver output enable on the bottom row. The packets are Start Of Frame (SOF), SETUP and DATA. The invalid SYNC generation occurs on any DATA packet being transmitted by the USBDPI model, ie. all packets following SETUP token packets or OUT token packets.
Corrected behavior with the full 8-bit SYNC signal KJKJKJKK:

Reference (from logic analyzer displaying traffic from real host controller):
