Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hw,gpio,rtl] Add support for RACL #26019

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[hw,gpio,rtl] Add support for RACL #26019

merged 1 commit into from
Jan 31, 2025

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Jan 26, 2025

This PR adds RACL support to the GPIO IP, similar to other IPs.

Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me, thanks.

hw/ip/gpio/rtl/gpio.sv Outdated Show resolved Hide resolved
@rswarbrick
Copy link
Contributor

CHANGE AUTHORIZED: hw/ip/gpio/data/gpio.hjson
CHANGE AUTHORIZED: hw/ip/gpio/rtl/gpio.sv
CHANGE AUTHORIZED: hw/ip/gpio/rtl/gpio_reg_top.sv
CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

The changes from this PR are all behind a parameter, which has its default (disabled) value in Earlgrey.

@Razer6
Copy link
Member Author

Razer6 commented Jan 27, 2025

@rswarbrick I just fixed the alignment nit.

Signed-off-by: Robert Schilling <[email protected]>
@Razer6
Copy link
Member Author

Razer6 commented Jan 30, 2025

@rswarbrick This has been rebased after the change from #26056

@vogelpi
Copy link
Contributor

vogelpi commented Jan 31, 2025

CHANGE AUTHORIZED: hw/ip/gpio/data/gpio.hjson
CHANGE AUTHORIZED: hw/ip/gpio/rtl/gpio.sv
CHANGE AUTHORIZED: hw/ip/gpio/rtl/gpio_reg_top.sv
CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

As per Rupert's assessment.

@vogelpi vogelpi merged commit bc1c4c7 into lowRISC:master Jan 31, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants