[hw,prim alert,rtl] Add flop repeater for alert signals #26022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
alert-flop-repeater
branch
from
343ab01 to
4d877c5
Compare
a-will
reviewed
Jan 26, 2025
There was a problem hiding this comment.
Should this module be generally discouraged for use with alerts on asynchronous clock domains? Given all the individual flops and the single domain used for both directions, the module doesn't give me the impression that it was intended for async use.
a-will
reviewed
Jan 26, 2025
| ) u_tx_p ( | ||
| .clk_i, | ||
| .rst_ni, | ||
| .d_i (alert_tx_i.alert_p), |
There was a problem hiding this comment.
Do these need prim_sec_anchor_buf to protect from optimizations that eliminate the second wire, as in prim_alert_receiver?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alerts are all collected by Darjeeling. IPs that are producing alerts are distributed in various places in the SoC, meaning there might a long distance to travel to Darjeeling. To cut the path, also when travelling across physical design partitions, it's necessary to flop signals, also alerts.
To make this easier, we add a repeater module tailored for alerts that flops both the TX and RX signal.