sphincsplus: accept PUB key as PEM encoded ASN.1 objects #26025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbendeb
requested review from
jon-flatley,
cfrantz and
pamaury
and removed request for
a team
|
support SPX key extraction from both raw and ANS.1 PEM files. |
|
guys, any comments on this? |
|
PTAL |
cfrantz
approved these changes
Jan 28, 2025
Some HSMs distribute SPX pub keys as PEM encoded ANS.1 objects. The approach so far has been to manually extract the 32 byte key material from the object. This patch adds parsing code for processing the ANS.1 key files. The supported algorithm is slh-dsa-sha2-128s-with-sha256, its OID is defined in https://csrc.nist.gov/projects/computer-security-objects-register/algorithm-registration#heading1725030685275_13 Tested on an opentitatn owner's firmware by passing to --spx-key first the raw SPX key and then the HSM generated PEM file, and observing the unchanged contents of the resulting image. Signed-off-by: Vadim Bendebury <[email protected]>
|
build error seems unrelated, can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some HSMs distribute SPX pub keys as PEM encoded ANS.1 objects. The approach so far has been to manually extract the 32 byte key material from the object. This patch adds parsing code for processing the ANS.1 key files.
The algorithm type is deduced from the ANN.1 OID, and is hardcoded to the value generated by Crypto4a HSM for SHA2 128S Simple encoding. This OID has not yet been standardized and could change in the future.
Tested on an opentitatn owner's firmware by passing to --spx-key first the raw SPX key and then the HSM generated PEM file, and observing the unchanged contents of the resulting image.