fix: cache warmup solution non legacy charts #2

dheeraj-jaiswal-lowes · 2023-02-06T12:15:48Z

SUMMARY

Issue: Cache-warmup API does not work as expected for all charts. Running cache-warmup for a slice ex: (vizType-Table) and exploring the same slice on browser gives different cache key.

Solution: /warm_up_cache/ API in current solution only applicable for legacy chart and when the same code executes for another type of chart such as Table chart and other non-legacy chart, it generates a different cache key not matching with the one we get while exploring the same slice on browser. Fix given here will check the viz type of the chart and handle it in the required way to update the right cache-key.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

Co-authored-by: Daniel Draper <[email protected]>

…#22516)

…checkbox-tree (apache#22585)

)

… 5.49.0 in /superset-websocket (apache#22838) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]>

…#22858) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…eact 18 upgrade (apache#22834)

…ache#22852)

…notation_json/<int:layer_id> (apache#22496)

apache#22815)

…cket (apache#22902) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…#22854)

…closing modal (apache#22937)

…t working (apache#22945)

…apache#22963)

…et-frontend (apache#22958) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]>

…et columns (apache#22943)

Co-authored-by: AAfghahi <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: lyndsiWilliams <[email protected]>

nandi-abhi · 2023-02-06T17:50:27Z

@dheeraj-jaiswal-lowes I believe, lot of changes from the public repo seem to be in the PR, I have synced the repo, please make sure the PR has the change associated with the specific feature/enhancement only

… suggestion

dheeraj-jaiswal-lowes · 2023-02-14T08:19:43Z

Will raise a separate one.

michael-s-molina and others added 30 commits January 23, 2023 10:25

fix: Unexpected error on simple filter (apache#22814)

d479009

feat(docker): Build multiple python version images (apache#22770)

931b01e

Co-authored-by: Daniel Draper <[email protected]>

fix: allow CSV upload in Other db (apache#22807)

3084763

chore: Convert direct uses of antd icons to 'Icons' component (apache…

2a30bbc

…#22516)

fix(sqllab): type error on renderBigIntStr (apache#22813)

02a3c0d

chore: upgrade react-datetime, react-intersection-observer and react-…

5f823b2

…checkbox-tree (apache#22585)

feat(helm): Add ability to customize affinity per deployment (apache#…

b132451

…22827)

chore(issue templates): discouraging Issues for feature requests (apa…

dde1e7c

…che#22617)

docs(alerts & reports): add, prune, reorganize (apache#20872)

3e07de7

chore(tests): Streamline Cypress login to fix fails/flakes (apache#22844

3898368

)

feat: export/import allow_dml flag (apache#22806)

6f0fed7

chore: Migrate /superset/recent_activity/<user_id>/ to /api/v1/ (apac…

050cbe9

…he#22789)

test: Fix act errors in DatasourceControl test (apache#22845)

ddd5cd3

test: Fix act errors in DatabaseModal test (apache#22846)

262c947

feat: Move cross filters to Dashboard (apache#22785)

9ed2326

fix(cpq): Add schema to Query.data() payload (apache#22791)

88a5d98

fix(Annotation Layers): Error when render options with renamed columns (

5da09bf

apache#22453)

build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.48.2 to…

8c38878

… 5.49.0 in /superset-websocket (apache#22838) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(misc): Spelling (apache#19678)

02e5dcb

Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]>

build(deps): bump ua-parser-js from 0.7.31 to 0.7.33 in /docs (apache…

a2ca246

…#22858) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

docs(cache): update doc strings (apache#22865)

f8edcd7

chore: migrate react-diff-viewer to react-diff-viewer-continued for r…

2400179

…eact 18 upgrade (apache#22834)

chore: upgrade react-table for react 18 upgrade (apache#22780)

6021d6f

chore: upgrade react-reverse-portal for react upgrade (apache#22779)

446d177

chore: removing unnecessary double spaces, a.k.a. "shotgun holes" (ap…

6998f65

…ache#22852)

fix: Convert TIMESTAMP_* to TIMESTAMP in Snowflake (apache#22872)

3fd4718

fix(sqllab): reverts apache#22695 (apache#22861)

0045816

feat(ssh_tunnel): Add feature flag to SSH Tunnel API (apache#22805)

d6a4a5d

fix: revert RESTful apis and react view for RLS (apache#22818)

8226110

chore: deprecate /superset/slice_json/<int:slice_id> and /superset/an…

bed10a0

…notation_json/<int:layer_id> (apache#22496)

Lily Kuang and others added 24 commits January 31, 2023 10:55

chore: migrate @vx/responsive to @visx/responsive for react 18 upgrade (

88119a9

apache#22815)

fix: fix warning in ssh tunnel (apache#22912)

16800cc

chore: upgrade packages for react v17 upgrade (apache#22914)

e80f878

chore: upgrade react-router-dom to 5.3.4 (apache#22878)

8dea7e1

build(deps-dev): bump eslint from 8.32.0 to 8.33.0 in /superset-webso…

08c3c4d

…cket (apache#22902) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat(helm): Make Chart.AppVersion default value for image tag (apache…

ede18be

…#22854)

chore: Migrate /superset/tables/* to API v1 (apache#22501)

02cd75b

fix(native-filters): Ensure that time range filter loses focus after …

eaf53db

…closing modal (apache#22937)

fix: Remove button is broken for metrics on Explore (apache#22940)

ebed50f

feat: Enable new dataset creation flow II (apache#22835)

260ac40

fix(datasets): Fix property selection on JSON response (apache#22944)

b410dbb

fix: Improve performance of CSV download (apache#22929)

98f4e90

test: Clean up AdhocFilterOption test warnings (apache#22915)

e13ebb6

chore: Bump Flask-AppBuilder constraints (apache#22927)

21a2e7b

chore(welcome): change default last tab to "all" (apache#22798)

b351907

fix(explore): Time comparison in Mixed Chart in GENERIC_CHART_AXES no…

ed7b353

…t working (apache#22945)

chore(superset-ui-chart-controls): refactor pivot and rename operator (…

c53c3aa

…apache#22963)

build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /supers…

deb5109

…et-frontend (apache#22958) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix(explore): unable to update linked charts (apache#22896)

ad1ffbd

chore(frontend): Spelling (apache#19676)

78ede59

Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]>

chore: add waitress for win32 platform (apache#22935)

56d4bd0

fix(datasets): Include expression and description in duplicated datas…

4b05a1e

…et columns (apache#22943)

feat: add tabs to edit dataset page (apache#22043)

c05871e

Co-authored-by: AAfghahi <[email protected]> Co-authored-by: Lyndsi Kay Williams <[email protected]> Co-authored-by: lyndsiWilliams <[email protected]>

querycontext

4ed6c14

dheeraj-jaiswal-lowes changed the title ~~fix: cache warmup solution non legacy charts~~ fix: cache warmup solution non legacy charts #15497 Feb 6, 2023

dheeraj-jaiswal-lowes changed the title ~~fix: cache warmup solution non legacy charts #15497~~ fix: cache warmup solution non legacy charts Feb 6, 2023

Removed constants charts array. handled the execution based on review…

369ff67

… suggestion

dheeraj-jaiswal-lowes closed this Feb 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cache warmup solution non legacy charts #2

fix: cache warmup solution non legacy charts #2

dheeraj-jaiswal-lowes commented Feb 6, 2023 •

edited

Loading

nandi-abhi commented Feb 6, 2023

dheeraj-jaiswal-lowes commented Feb 14, 2023

fix: cache warmup solution non legacy charts #2

fix: cache warmup solution non legacy charts #2

Conversation

dheeraj-jaiswal-lowes commented Feb 6, 2023 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

nandi-abhi commented Feb 6, 2023

dheeraj-jaiswal-lowes commented Feb 14, 2023

dheeraj-jaiswal-lowes commented Feb 6, 2023 •

edited

Loading