-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show packages through winget #85
Conversation
Cool, code looks fine, except you forgot to add package manager name The other thing is while it makes sense for |
This was actually intentional. The winget listing does not show packages installed by winget, it shows all the packages ever installed on the machine. (It mirrors the Programs list in Control Panel). In my case I had observed two newlines in the beginning, then a header line, then the horizontal divider. So this makes it 4 extra lines. (both in Windows PowerShell and PowerShell Core) Yes, I do agree that we should not have winget shown by default, since it fetches all those programs it takes quite some time. |
Sure, but you should always be clear where you're getting that information from, people using winget should already be aware that it lists all packages, otherwise filter only rows that have
Mine only has 1 newline at the beginning, make sure you're using the latest version of winget, otherwise, just strip trailing newlines first then do the count. |
That's not how it works. The entries that have winget as their source just means that that package is available in winget repos. It does not mean that that package has been installed through winget. I have 5 out of 140 programs that mention winget in their source, but 0 of them were installed via winget. I think what needs to be understood is that winget is not a traditional 'package manager', it's more of a generic program manager. Or, to be more pedantic, it's a CLI version of Control Panel's Programs page. And people using winget are most likely to be aware of this distinction. Mentioning And also, I'm on the latest version, v1.0.11451. |
Well, no package can "technically" be installed through winget and there's no way to differentiate between a package installed through winget or not, just whether they can be installed/updated through winget.
If you're listing all packages then I get what you mean, but saying nothing and listing it in the packages section is not ideal either, but I suppose if this is something people manually enable then they'll at least be able to tell what it refers to. |
Exactly. This is also another reason to keep it off by default I guess. |
I have improved the counting part a bit and disabled winget by default. |
As per #83