-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change user, host, and rowname colors to yellow for better visibility #97
Conversation
Hmm, I remember coming across this readability issue when testing out with the default PowerShell color scheme. Seems fair to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The premise is good I'm just not sure about the color choice, I think we should go with cyan instead, this is the color neofetch uses and it also keeps with the blue theme of the windows logo. As for the legacy logo, we can either just go with the cyan for simplicity or switch to another color (a green/red might look nicer than the yellow).
Cyan on a dark blue background seems like unreadable. Yellow has the maximum contrast on that background (that's why PSReadline uses yellow by default). |
I mean look at the image I sent or try it on your own machine the bright cyan is pretty readable and keeps with the windows blue theme.
The screenshots were just examples of alternatives, they are the color schemes that neofetch uses by default. The difference between the title and info is irrelevant. |
That's not the colour I used, I said bright cyan, on the colour bar it's the 2nd from the right on the bottom row.
it was "irrelevant" to the point I was making, we don't current use a different colour for the title (i.e. user@host) and info titles and I wasn't talking about changing that. |
@jcwillox this is awaiting your approval. |
Thanks, forgot about this PR 👍 On a related note, we may want to consider adding some sort of text colour option in the future |
That's a nice feature suggestion! |
is there any way to change the colour of the text? as i dont much like the yellow. |
Not yet |
Dark blue on black is kind of hard to read.
If you're actually using the old powershell terminal with its default colors, it's a bit harder than that.
When you have something like f.lux on, it can be almost illegible if you forget to shut it off for your terminal app--and if you normally don't do this, why would you? (I tried to capture this with a screenshot but the colors are getting mangled right now).
Yellow on black and yellow on blue, though, both read easily.
Seems like an easy quality-of-life win. (Screenshots censored to remove my user and host, but I have also changed the code so that their colors are also changed from blue to yellow.)