-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG rendering #16
SVG rendering #16
Conversation
Fixes #7 You can (automatically) let issues close when a PR is merged. |
Added a svg mode. I think the lib you use is way to heavy for a simply svg mode addition, makes the dist size ~6x as heavy. |
Hmm, seems to be done in 3b8216e. @werthdavid do you maybe want to comment on that? If upstream now has SVG support #7 is basically solved… So why should one use your fork? (Are there other advantages that justify that additional size?) 🤔 |
There's a hand full of differences in my fork but the basic idea was the svg rendering. now that @lrsjng is "back" we can also close my forked version. Would you be interested in those changes in the original kjua? I could make a PR then. |
Made some changes not related to JS code. If you consider merging this, I can update the PR so only the changes relevant for SVG rendering will be merged.