Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG rendering #16

Closed
wants to merge 31 commits into from
Closed

SVG rendering #16

wants to merge 31 commits into from

Conversation

werthdavid
Copy link

Made some changes not related to JS code. If you consider merging this, I can update the PR so only the changes relevant for SVG rendering will be merged.

@rugk
Copy link

rugk commented Jul 27, 2019

Fixes #7

You can (automatically) let issues close when a PR is merged.

README.md Show resolved Hide resolved
@lrsjng
Copy link
Owner

lrsjng commented Jul 25, 2020

Added a svg mode. I think the lib you use is way to heavy for a simply svg mode addition, makes the dist size ~6x as heavy.

@lrsjng lrsjng closed this Jul 25, 2020
@rugk
Copy link

rugk commented Jul 26, 2020

Hmm, seems to be done in 3b8216e.
(Also maybe it would be useful to use proper commit messages, so they are any useful. 🤔)

@werthdavid do you maybe want to comment on that? If upstream now has SVG support #7 is basically solved… So why should one use your fork? (Are there other advantages that justify that additional size?) 🤔

@werthdavid
Copy link
Author

There's a hand full of differences in my fork but the basic idea was the svg rendering. now that @lrsjng is "back" we can also close my forked version. Would you be interested in those changes in the original kjua? I could make a PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants