-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add Helios-based deployment workflow for test servers and reusable build logic
#10109
Conversation
I have refactored the Build workflow runs can be seen in this link. Once this PR is merged, and the time comes to remove the current labeling logic, we can create another PR to move the contents of the Below are my testing outputs of this new Deployment from a Branch Without a PRWorkflow run: https://github.com/ls1intum/Artemis/actions/runs/12948960943 ![]() Deployment from a Branch with a PRWhen deploying from a branch with an open pull request, the workflow first verifies whether the latest build was successful. If the build is successful, the deployment proceeds. Otherwise, it fails. Scenario 1: Build Still Running During Deployment (No Successful Build Found)Workflow run: https://github.com/ls1intum/Artemis/actions/runs/12949128976 ![]() Scenario 2: Successful Build FoundWorkflow run: https://github.com/ls1intum/Artemis/actions/runs/12949268370 ![]() Note: The new workflow was tested by temporarily modifying the testserver.yml file to enable testing, as the workflow has not yet been merged into the default branch. (See add2b32 and 925a07f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for integrating the feedback. code looks good, really like the refactoring 👍
40aef2d
Development
: Add Helios-based deployment workflow for test serversDevelopment
: Add Helios-based deployment workflow for test servers and reusable build logic
Checklist
General
Motivation and Context
This PR adds a new action file
testserver-deployment.yml
to integrate with the Helios web application for test server deployments. The current label-based approach for triggering deployments will be replaced with this newworkflow_dispatch
based workflow.Additionally, the
build.yml
workflow has been refactored to leverage a reusable workflow file (reusable-build.yml
). This ensures consistency across workflows and simplifies future maintenance.Description
Integration with Helios:
Reusable Build Workflow:
reusable-build.yml
to streamline build logic.build.yml
workflow has been updated to utilize this reusable workflow.testserver-deployment.yml
workflow also utilizes the reusable workflow to handle deployment scenarios where builds are not found.testserver-deployment.yml:
workflow-dispatch
approach.testserver-deployment.yml
intotestserver.yml
.Once this PR is merged, a follow-up PR will finalize the transition by moving the contents of
testserver-deployment.yml
intotestserver.yml
.