Exam mode: Do not display timer for unsubmitted exams
#7539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
client
florian-glombik
added
enhancement
component:Exam Mode
client
florian-glombik
changed the title
Exam mode: Do not display timer for unsubmitted examExam mode: Not displaying timer for unsubmitted exam
florian-glombik
changed the title
Exam mode: Not displaying timer for unsubmitted examExam mode: Not displaying timer for unsubmitted exams
src/test/javascript/spec/component/exam/participate/exam-participation-cover.component.spec.ts
Outdated
Show resolved
Hide resolved
FiasKr
suggested changes
Nov 8, 2023
JanaNF
previously approved these changes
Nov 8, 2023
|
github-actions
bot
added
deployment-error
LenaKahle
temporarily deployed
to
artemis-test3.artemis.cit.tum.de
GitHub Actions
Inactive
27 tasks
|
github-actions
bot
added
the
deployment-error
MaximilianJG
added
deploy:artemis-test4
and removed
deployment-error
MaximilianJG
temporarily deployed
to
artemis-test4.artemis.cit.tum.de
GitHub Actions
Inactive
Gusti2010
approved these changes
Nov 15, 2023
Ceiridge
temporarily deployed
to
artemis-test1.artemis.cit.tum.de
GitHub Actions
Inactive
Ceiridge
temporarily deployed
to
artemis-test2.artemis.cit.tum.de
GitHub Actions
Inactive
|
Tested with @MaximilianJG on test2. Everything worked as expected. (See his comment for screenshots) |
|
Worked as expected. Tested in a exam testing session with @Ceiridge. Timer is displaying during exam and also after grace period. 
Also, timer if grace period is over is not shown anymore: |
krusche
changed the title
Exam mode: Not displaying timer for unsubmitted examsExam mode: Do not display timer for unsubmitted exams
krusche
deleted the
enhancement/exam/do-not-display-time-for-unsubmitted-exam
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Client
Motivation and Context
The timer is unnecessary, and it seems a bit broken to display
left time 0:0when the exam and grace period is over.Description
Does not display the timer anymore after the exam is over, which was the case before for unsubmitted exams.
Exam Mode Testing
Instructor: Prepare an examStudent: Verify the timer is still displayed during the examStudent: Do not submit the examStudent: wait until the grace period is overStudent: Try to open the exam summaryStudent: See that the timer is still displayed, which would not be necessaryTestserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Code Review
Manual Tests
Test Coverage
Screenshots
New
Old