Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz exercises: Fix stuck loading cycle for competency selector in quiz exercise edit view #7612

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

MaximilianAnzinger
Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger commented Nov 17, 2023

Checklist

General

  • I tested all changes and their related features with all corresponding user types on a test server.
  • This is a small issue that I tested locally and was confirmed by another developer on a test server.
  • I chose a title conforming to the naming conventions for pull requests.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I documented the TypeScript code using JSDoc style.

Motivation and Context

Description

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Course WITHOUT Competencies
  1. Log in to Artemis
  2. Navigate to Course Administration
    For each Exercise type:
  3. Create Exercise
  4. Check if you see a loading animation for the competency selector. Either the selector disappears after a short time OR it disappeared so quickly you didn't have time to see it. Both cases are fine.
  5. Continue with the next Exercise type (step 3.) until all are covered

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Client

Class/File Line Coverage Confirmation (assert/expect)
competency-selection.component.ts 88.63%

Screenshots

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Nov 17, 2023
Copy link

@JanaNF JanaNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual tested on legacy_ts2. Worked as expected

Copy link

@xHadie xHadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested on TS2_Legacy
LGTM - Works as you described.

Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

Copy link
Contributor

@sarpsahinalp sarpsahinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts2. Seems to be working

Copy link

@FiasKr FiasKr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Legacy TS3, seems to be working fine :)

@MaximilianJG
Copy link
Contributor

Everything worked as expected. I cannot see the competency selector and also no competency selector loading animation when creating the different exercises

Uploading Screenshot 2023-11-20 at 14.05.17.png…

@krusche krusche added this to the 6.7.0 milestone Nov 22, 2023
@krusche krusche merged commit 73a7b57 into develop Nov 22, 2023
21 of 31 checks passed
@krusche krusche deleted the bugfix/competency-selector branch November 22, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) ready to merge small tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants