Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Fix the display of students after exam conduction #7615

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

maximiliansoelch
Copy link
Member

@maximiliansoelch maximiliansoelch commented Nov 17, 2023

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.

Motivation and Context

Fixes #7614

Description

Removes the check for only returning students in case student exams exist (if (studentExams!.length > 0)) + uses optional chaining to prevent runtime errors in case no student exam was generated for a student (didExamUserAttendExam: !!studentExam?.started).

Steps for Testing

Prerequisites:

  1. Go to the exam overview page
  2. For the exam, which conforms to the conditions mentioned in the prerequisites, click on the Students button
  3. All registered students should be displayed

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

@maximiliansoelch maximiliansoelch requested a review from a team as a code owner November 17, 2023 20:44
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Nov 17, 2023
Copy link

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Nov 17, 2023
@krusche krusche added this to the 6.6.7 milestone Nov 17, 2023
Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm
Manual on legacy TS1
Thx for the quick fix 👍

@MaximilianAnzinger MaximilianAnzinger removed the deployment-error Added by deployment workflows if an error occured label Nov 17, 2023
@krusche krusche merged commit dbc2c6f into develop Nov 17, 2023
38 of 42 checks passed
@krusche krusche deleted the fix/exam/view-students-after-exam-has-ended branch November 17, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exam mode: Students not displayed after exam conduction
3 participants