-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Add custom build scripts for local continuous integration
#7619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual tested on legacy_ts11. Worked as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS6, works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally, works as expected, code also lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving code
Quality and changes look good to me.
Checklist
General
Server
Motivation and Context
This PR builds on #7528 and adds basic support for custom build scripts in Local CI.
Description
Instructors can define script actions in the client during exercise creation which are then persisted in the database. During the set up of the build job container, these actions are retrieved for the build script.
Steps for Testing
Only test on TS3, TS5 or legacy TS11. Or test locally with LocalVC Local CI run configuration
Prerequisites:
echo "Hello World"
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests