Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Fix checkstyle issues in server code documentation #7634

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Development: Fix checkstyle issues in server code documentation #7634

merged 3 commits into from
Nov 22, 2023

Conversation

jakubriegel
Copy link
Contributor

@jakubriegel jakubriegel commented Nov 20, 2023 •
edited
Loading

Checklist

General

Motivation and Context

There was a missing @param comment in ProgramingPlagiarismDetectionService`, which caused server style to fail.

Description

This PR adds the missing comment.

Steps for Testing

  • code review

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@jakubriegel jakubriegel self-assigned this Nov 20, 2023
@jakubriegel jakubriegel marked this pull request as ready for review November 20, 2023 09:48
@jakubriegel jakubriegel requested a review from a team as a code owner November 20, 2023 09:48
@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Nov 20, 2023
@krusche krusche changed the title Development: Add missing @param doc Development: Fix server code style Nov 20, 2023
@krusche krusche changed the title Development: Fix server code style Development: Fix check style issues in server code documentation Nov 20, 2023
@krusche krusche added this to the 6.7.0 milestone Nov 20, 2023
@github-actions GitHub Actions
Copy link

⚠️ Unable to deploy to test servers ⚠️

Testserver "artemis-test6.artemis.cit.tum.de" is already in use by PR #7419.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Nov 20, 2023
@jakubriegel jakubriegel removed the deployment-error Added by deployment workflows if an error occured label Nov 20, 2023
@github-actions github-actions bot added deployment-error Added by deployment workflows if an error occured and removed deploy:artemis-test6 labels Nov 20, 2023
@matthiaslehnertum matthiaslehnertum added deploy:artemis-test6 and removed deployment-error Added by deployment workflows if an error occured labels Nov 20, 2023
@github-actions github-actions bot added deployment-error Added by deployment workflows if an error occured and removed deploy:artemis-test6 labels Nov 20, 2023
xHadie
xHadie approved these changes Nov 20, 2023
View reviewed changes
Copy link

@xHadie xHadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM!

@b-fein b-fein changed the title Development: Fix check style issues in server code documentation Development: Fix checkstyle issues in server code documentation Nov 20, 2023
egekurt123
egekurt123 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@egekurt123 egekurt123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubriegel jakubriegel added ready to merge ready for review and removed deployment-error Added by deployment workflows if an error occured ready for review ready to merge labels Nov 20, 2023
@jakubriegel jakubriegel mentioned this pull request Nov 21, 2023
Merged
14 tasks
@krusche krusche merged commit de43897 into develop Nov 22, 2023
27 of 31 checks passed
@krusche krusche deleted the plagiarism-checks-add-missing-doc branch November 22, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egekurt123 egekurt123 egekurt123 approved these changes

@b-fein b-fein b-fein approved these changes

@MaximilianAnzinger MaximilianAnzinger MaximilianAnzinger approved these changes

@xHadie xHadie xHadie approved these changes

@Strohgelaender Strohgelaender Strohgelaender approved these changes

@Hialus Hialus Hialus approved these changes

@reschandreas reschandreas reschandreas approved these changes

@MarkusPaulsen MarkusPaulsen Awaiting requested review from MarkusPaulsen

Assignees

@jakubriegel jakubriegel

Labels
ready for review server Pull requests that update Java code. (Added Automatically!)
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.
10 participants
@jakubriegel @reschandreas @Hialus @Strohgelaender @xHadie @MaximilianAnzinger @b-fein @egekurt123 @krusche @matthiaslehnertum