-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Convert to new control flow syntax in Angular 17
#7751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did a thorough code review and looks good to me :^)
Code Review + Manual Test for the Orion Components they look good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Quiz Exercises and Exam mode (All Exercise Type). Couldn't find any noticeable errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Programming exercises and user settings in a testing session
…nd fix html lint issues (#7775)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked all @switch
statements, there are no overlapping cases left. Also looked at the manual changes, they look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Checklist
General
Client
Motivation and Context
The new control flow syntax is easier to understand.
Closes #7773.
Description
The code is automatically converted using
ng generate @angular/core:control-flow
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Testing steps
Test the main functionality and check that everything still works correctly.
Especially test places where we use multiple containers on the same page (e.g. the code editor, the assessment view of any exercise type, the exam mode) and check that the projected content is visible.
Review Progress
Code Review