Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Convert to new control flow syntax in Angular 17 #7751

Merged
merged 23 commits into from
Dec 13, 2023

Conversation

krusche
Copy link
Member

@krusche krusche commented Dec 8, 2023

Checklist

General

Client

Motivation and Context

The new control flow syntax is easier to understand.
Closes #7773.

Description

The code is automatically converted using ng generate @angular/core:control-flow

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Testing steps

Test the main functionality and check that everything still works correctly.

Especially test places where we use multiple containers on the same page (e.g. the code editor, the assessment view of any exercise type, the exam mode) and check that the projected content is visible.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@krusche krusche requested a review from a team as a code owner December 8, 2023 16:53
@krusche krusche added this to the 6.7.3 milestone Dec 8, 2023
@krusche krusche self-assigned this Dec 8, 2023
MichaelOwenDyer
MichaelOwenDyer previously approved these changes Dec 8, 2023
Copy link
Contributor

@MichaelOwenDyer MichaelOwenDyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a thorough code review and looks good to me :^)

@Strohgelaender Strohgelaender added the client Pull requests that update TypeScript code. (Added Automatically!) label Dec 8, 2023
@Strohgelaender Strohgelaender added server Pull requests that update Java code. (Added Automatically!) and removed server Pull requests that update Java code. (Added Automatically!) labels Dec 11, 2023
@Kroko-fant
Copy link
Contributor

Code Review + Manual Test for the Orion Components they look good to me

rriyaldhi
rriyaldhi previously approved these changes Dec 11, 2023
Copy link
Contributor

@rriyaldhi rriyaldhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Quiz Exercises and Exam mode (All Exercise Type). Couldn't find any noticeable errors.

Kroko-fant
Kroko-fant previously approved these changes Dec 11, 2023
Copy link
Contributor

@Kroko-fant Kroko-fant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Programming exercises and user settings in a testing session

@krusche krusche dismissed stale reviews from Kroko-fant and rriyaldhi via c7d69cd December 11, 2023 18:50
Copy link
Contributor

@valentin-boehm valentin-boehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all @switch statements, there are no overlapping cases left. Also looked at the manual changes, they look good.

@aplr aplr self-requested a review December 13, 2023 10:27
Copy link
Contributor

@aplr aplr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krusche krusche merged commit d49d437 into develop Dec 13, 2023
29 of 32 checks passed
@krusche krusche deleted the chore/angular17-control-flow branch December 13, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development: Add lint rule to enforce Angular 17 control flow syntax
9 participants