Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Avoid database queries with pagination and left join fetch #8741

Merged
merged 76 commits into from
Aug 8, 2024

Merge branch 'develop' into chore/avoid-pagination-with-fetch

333daa4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Development: Avoid database queries with pagination and left join fetch #8741

Merge branch 'develop' into chore/avoid-pagination-with-fetch
333daa4
Select commit
Loading
Failed to load commit list.
GitHub Actions / Java Architecture Tests succeeded Aug 6, 2024 in 1s

54 passed, 0 failed and 0 skipped

Tests passed successfully

Report Passed Failed Skipped Time
build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.ArchitectureTest.xml 20✅ 5s
build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.EnforceRoleInResourceArchitectureTest.xml 2✅ 224ms
build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.FeedbackArchitectureTest.xml 2✅ 443ms
build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.RepositoryArchitectureTest.xml 11✅ 315ms
build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.ResourceArchitectureTest.xml 4✅ 100ms
build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.ServiceArchitectureTest.xml 5✅ 224ms
build/test-results/test/TEST-de.tum.in.www1.artemis.authorization.AuthorizationArchitectureTest.xml 8✅ 75ms
build/test-results/test/TEST-de.tum.in.www1.artemis.domain.notification.NotificationPlaceholderArchitectureTest.xml 2✅ 29ms

✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.ArchitectureTest.xml

20 tests were completed in 5s with 20 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.in.www1.artemis.architecture.ArchitectureTest 20✅ 5s

✅ de.tum.in.www1.artemis.architecture.ArchitectureTest

✅ ensureSpringComponentsAreProfileAnnotated()
✅ testNoJunitJupiterAssertions()
✅ hasMatchingAuthorizationTestClassBeCorrectlyImplemented()
✅ testFileWriteUsage()
✅ testCorrectStringUtils()
✅ testValidSimpMessageSendingOperationsUsage()
✅ testLogging()
✅ testNoHazelcastUsageInConstructors()
✅ testJSONImplementations()
✅ testNoRestControllersImported()
✅ testNoDirectGitCommitCalls()
✅ testNoCollectorsToList()
✅ testClassNameAndVisibility()
✅ testGsonExclusion()
✅ testNoJUnit4()
✅ testDTOImplementations()
✅ shouldNotUserAutowiredAnnotation()
✅ testCorrectLoggerFields()
✅ testJsonIncludeNonEmpty()
✅ testNullnessAnnotations()

✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.EnforceRoleInResourceArchitectureTest.xml

2 tests were completed in 224ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.in.www1.artemis.architecture.EnforceRoleInResourceArchitectureTest 2✅ 224ms

✅ de.tum.in.www1.artemis.architecture.EnforceRoleInResourceArchitectureTest

✅ testEnforceRoleInExerciseEndpointHasExerciseIdParameter()
✅ testEnforceRoleInCourseEndpointHasCourseIdParameter()

✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.FeedbackArchitectureTest.xml

2 tests were completed in 443ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.in.www1.artemis.architecture.FeedbackArchitectureTest 2✅ 443ms

✅ de.tum.in.www1.artemis.architecture.FeedbackArchitectureTest

✅ testSetLongFeedbackTextNotUsed()
✅ testGetLongFeedbackTextNotUsed()

✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.RepositoryArchitectureTest.xml

11 tests were completed in 315ms with 11 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.in.www1.artemis.architecture.RepositoryArchitectureTest 11✅ 315ms

✅ de.tum.in.www1.artemis.architecture.RepositoryArchitectureTest

✅ testNoEntityGraphsOnQueries()
✅ testNoUnusedRepositoryMethods()
✅ testTransactional()
✅ shouldBeInRepositoryPackage()
✅ testRepositoryParamAnnotation()
✅ orElseThrowShouldNotBeCalled()
✅ repositoriesImplementArtemisJpaRepository()
✅ persistenceShouldNotAccessServices()
✅ testJPQLStyle()
✅ shouldBeNamedRepository()
✅ testOnlySpringTransactionalAnnotation()

✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.ResourceArchitectureTest.xml

4 tests were completed in 100ms with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.in.www1.artemis.architecture.ResourceArchitectureTest 4✅ 100ms

✅ de.tum.in.www1.artemis.architecture.ResourceArchitectureTest

✅ allPublicMethodsShouldReturnResponseEntity()
✅ shouldBeNamedResource()
✅ shouldBeInResourcePackage()
✅ shouldCorrectlyUseRequestMappingAnnotations()

✅ build/test-results/test/TEST-de.tum.in.www1.artemis.architecture.ServiceArchitectureTest.xml

5 tests were completed in 224ms with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.in.www1.artemis.architecture.ServiceArchitectureTest 5✅ 224ms

✅ de.tum.in.www1.artemis.architecture.ServiceArchitectureTest

✅ testCorrectAsyncCalls()
✅ shouldBeNamedService()
✅ testCorrectServiceAnnotation()
✅ shouldBeInServicePackage()
✅ testNoWrongServiceImports()

✅ build/test-results/test/TEST-de.tum.in.www1.artemis.authorization.AuthorizationArchitectureTest.xml

8 tests were completed in 75ms with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.in.www1.artemis.authorization.AuthorizationArchitectureTest 8✅ 75ms

✅ de.tum.in.www1.artemis.authorization.AuthorizationArchitectureTest

✅ testEnforceAdminAnnotations()
✅ testEnforceAtLeastEditorAnnotations()
✅ testNoPreAuthorizeOnRestEndpoints()
✅ testEnforceAtLeastTutorAnnotations()
✅ testEnforceAtLeastInstructorAnnotations()
✅ testEnforceAtLeastStudentAnnotations()
✅ testEnforceNothingAnnotations()
✅ testNoPreAuthorizeOnRestControllers()

✅ build/test-results/test/TEST-de.tum.in.www1.artemis.domain.notification.NotificationPlaceholderArchitectureTest.xml

2 tests were completed in 29ms with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
de.tum.in.www1.artemis.domain.notification.NotificationPlaceholderArchitectureTest 2✅ 29ms

✅ de.tum.in.www1.artemis.domain.notification.NotificationPlaceholderArchitectureTest

✅ testNotificationPlaceholderCreatorStringArrayCreation()
✅ testPlaceholderCreatorMethodSignature()
View more details on GitHub Actions