Communication: Fix empty gray area in sidebar accordion with no items

[asliayk]

Checklist

General

• This is a small issue that I tested locally.
• I chose a title conforming to the naming conventions for pull requests.

Client

• I strictly followed the client coding and design guidelines.
• I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The sidebar accordion of communication section should not render unnecessary empty areas when there are no items to display.
Closes #9002

Description

The updated sidebar accordion component includes a conditional check to prevent rendering of empty collapsible sections.

Steps for Testing

Prerequisites:

• 1 Instructor

1. Go to Course Management page
2. Click Communications button of a course
3. Click an empty option in the collapsible menu
4. Notice that nothing appears under the accordion anymore (no gray empty area).

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Exam Mode Test

• Test 1
• Test 2

Test Coverage

Screenshots

OLD

NEW

Summary by CodeRabbit

• New Features

  • Improved sidebar accordion functionality to dynamically display items based on search results.

• Style

  • Enhanced UI consistency by adjusting the placement of horizontal lines in the sidebar.

[coderabbitai]

Walkthrough

The changes focus on enhancing the sidebar accordion component's user interface by dynamically adjusting the display based on search results. This improvement involves conditional rendering to either show the content or hide unnecessary separators, ensuring a cleaner and more intuitive user experience when no options are available.

Changes

File Path	Change Summary
src/main/webapp/app/shared/sidebar/sidebar-accordion/sidebar-accordion.component.html	Removed unnecessary <hr> tag before the content section, updated conditional rendering to check for filtered entity data length, and moved <hr> inside the collapsed state block.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Remove unnecessary gray area in empty dropdown (Issue #9002)	✅
Ensure collapsible menu does not expand when no options are available (Issue #9002)	✅
Display a message like "No options available" instead of an empty area (Issue #9002)	❌	The changes do not include displaying a message; they merely prevent the expansion of empty dropdowns.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[PaRangger]

Tested on TS6. No more empty grey bar in the menus. ✅ Code looks good too 👍🏼

(Personally I would prefer an "empty" message/icon when clicking the menus. Because now we can click on empty menus, it will spin the chevron on the right, but nothing shows up. But maybe that's just me 🤤)

[github-actions]

⚠️ Unable to deploy to test servers ⚠️

Testserver "artemis-test5.artemis.cit.tum.de" is already in use by PR #9028.

[github-actions]

⚠️ Unable to deploy to test servers ⚠️

Testserver "artemis-test4.artemis.cit.tum.de" is already in use by PR #8982.

[edkaya]

Tested on ts6, works as expected. There is no gray area in sidebar accordion with 0 elements after uncollapsing it. Code also lgtm

[sarpsahinalp]

Tested locally works as expected