-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix rephrasing Pipeline #199
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/pipeline/rewriting_pipeline.py (1)
56-56
: LGTM! The hotfix addresses the missing argument.The addition of
tools=None
parameter to thechat
method call aligns with the PR objectives and should prevent the application from crashing.However, there's a minor formatting issue that needs to be fixed:
- [prompt], CompletionArguments(temperature=0.4), tools = None + [prompt], CompletionArguments(temperature=0.4), tools=None🧰 Tools
🪛 GitHub Actions: Run linters
[warning] File needs to be reformatted using Black code formatter
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/pipeline/rewriting_pipeline.py
(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Run linters
app/pipeline/rewriting_pipeline.py
[warning] File needs to be reformatted using Black code formatter
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build and Push Docker Image
Also contained in #192 |
Seems to be an empty PR now. :) |
#196 introduced a new necessary argument for the request_handler.chat method, which is not accordingly updated in the Rewrite pipeline (#191).
We did not spot this during merging, so this PR introduces sets this required variable to 0 so it does not crash any longer
Summary by CodeRabbit
tools
parameter.tools
argument (set toNone
).