-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature
: Add basic FAQ functionality
#403
Conversation
...n/de/tum/informatics/www1/artemis/native_app/feature/faq/ui/FaqArtemisMarkdownTransformer.kt
Outdated
Show resolved
Hide resolved
Are you sure it's TS2? I just went there, but there was no FAQ enabled. I also checked the web app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall really nice, I didn't experience any issues while testing.
I tested on TS2 using Practical Course: Interactive Learning SS24
.
Just two concerns regarding changes that have been made on other branches. I don't know, which PR gets merged first, but I wanted to point it out here so that the other PR which gets merged second can make include the changes before.
The rest of the code seems fine :)
...n/kotlin/de/tum/informatics/www1/artemis/native_app/feature/faq/ui/overview/FaqOverviewUi.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/de/tum/informatics/www1/artemis/native_app/feature/faq/ui/overview/FaqOverviewUi.kt
Show resolved
Hide resolved
Okay thats weird. I really dont know why it got disabled again 🧐. Anyways, I re-enabled faqs on that "TS2 > Test Course Martin Felber" again and testing should work |
# Conflicts: # feature/course-view/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/courseview/ui/course_overview/CourseScaffold.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, everything works as expected. Images get rendered correctly, tested on TS2 in your test course.
Code lgtm. Can be merged!
If you want to merge this first, I can go ahead and include the ArtemisSearchTopAppBar in #407 or vice versa :)
Problem Description
The Android app did not yet support the FAQ feature provided by the Webapp and iOS.
Changes
FaqRepository
that will further be used to hide the logic of remote and local storage (will be added in FAQ: Support offline storage of faqs #400 )Steps for testing
On "TS2 > Test Course Martin Felber" I enabled FAQs and created some sample FAQs.
Screenshots
Overview:
![](https://private-user-images.githubusercontent.com/45291671/411703095-f74bb6b5-bb09-4efd-977e-7666b132f7a8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTI4NDksIm5iZiI6MTczOTY1MjU0OSwicGF0aCI6Ii80NTI5MTY3MS80MTE3MDMwOTUtZjc0YmI2YjUtYmIwOS00ZWZkLTk3N2UtNzY2NmIxMzJmN2E4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIwNDkwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMyNDNiZDhmMzM4MjFiMDMyODJlZjgxY2FhNWQzMDM1YWI5Y2NjNzgzMmMwZDhkYzE0OWM0NzJjOGYyYzAxYzQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.h2n_bk74ZKNicB8XymyJ3xfX9ceVpSqfsBsKivQP6G8)
Details:
![](https://private-user-images.githubusercontent.com/45291671/411703313-2dc6998b-6ce2-45e7-9288-b6a58b545d6e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTI4NDksIm5iZiI6MTczOTY1MjU0OSwicGF0aCI6Ii80NTI5MTY3MS80MTE3MDMzMTMtMmRjNjk5OGItNmNlMi00NWU3LTkyODgtYjZhNThiNTQ1ZDZlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDIwNDkwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMwOTliNjM3ODNiODI3ODJiOTNkYTY5MTgyMThiMGM0Mjc5NTg0YzgxMWQzMWVjNGQ5OThjMjA1ZDUxZmQ4MDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KS2Uizt3yFvWjVlpQmc-9jjLomas-XYZ4mZw0ewQw8s)
Follow-ups
See sub-issues of #90