Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add basic FAQ functionality #403

Merged
merged 25 commits into from
Feb 14, 2025
Merged

Conversation

FelberMartin
Copy link
Collaborator

@FelberMartin FelberMartin commented Feb 10, 2025

Problem Description

The Android app did not yet support the FAQ feature provided by the Webapp and iOS.

Changes

  • Added faq and faq-test feature modules
  • Added Overview and Detail screen
  • Show faq BottomNavItem if faq is enabled for that course
  • Introduced FaqRepository that will further be used to hide the logic of remote and local storage (will be added in FAQ: Support offline storage of faqs #400 )
  • Added UI tests

Steps for testing

On "TS2 > Test Course Martin Felber" I enabled FAQs and created some sample FAQs.

  • Go to a course with FAQ enabled
  • See that BottomNavItem is displayed
  • Browse through FAQs and ensure everthing works as intented

Screenshots

Overview:

Details:

Follow-ups

See sub-issues of #90

@FelberMartin FelberMartin self-assigned this Feb 10, 2025
@FelberMartin FelberMartin added the ready for review This PR can be reviewed label Feb 10, 2025
@julian-wls
Copy link
Contributor

On "TS2 > Test Course Martin Felber" I enabled FAQs and created some sample FAQs.

Are you sure it's TS2? I just went there, but there was no FAQ enabled. I also checked the web app.

Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall really nice, I didn't experience any issues while testing.
I tested on TS2 using Practical Course: Interactive Learning SS24.

Just two concerns regarding changes that have been made on other branches. I don't know, which PR gets merged first, but I wanted to point it out here so that the other PR which gets merged second can make include the changes before.
The rest of the code seems fine :)

@FelberMartin
Copy link
Collaborator Author

Are you sure it's TS2? I just went there, but there was no FAQ enabled. I also checked the web app.

Okay thats weird. I really dont know why it got disabled again 🧐. Anyways, I re-enabled faqs on that "TS2 > Test Course Martin Felber" again and testing should work

@ls1intum ls1intum deleted a comment from julian-wls Feb 13, 2025
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, everything works as expected. Images get rendered correctly, tested on TS2 in your test course.
Code lgtm. Can be merged!

If you want to merge this first, I can go ahead and include the ArtemisSearchTopAppBar in #407 or vice versa :)

@FelberMartin FelberMartin added ready to merge This PR can be merged and removed ready for review This PR can be reviewed labels Feb 14, 2025
@FelberMartin FelberMartin merged commit a429a9c into develop Feb 14, 2025
5 checks passed
@FelberMartin FelberMartin deleted the feature/add-basic-faq branch February 14, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants