Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix too early truncate of feedbacks #34

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Fix too early truncate of feedbacks #34

merged 2 commits into from
Jul 18, 2023

Conversation

Strohgelaender
Copy link
Collaborator

@Strohgelaender Strohgelaender commented Jul 7, 2023 •
edited
Loading

Checklist

  • I built and deployed the plugin locally and tested all changes and all related features.
  • I documented the Java code using JavaDoc style.

Motivation and Context

Artemis now supports long feedback, so we don't need to cut Feedback in the bamboo plugin.

Description

I changed the maxium feedback length to the hard limit of long feedback in Artemis.

Steps for Testing

see ls1intum/Artemis#6856

@Strohgelaender Strohgelaender mentioned this pull request Jul 7, 2023
Merged
16 tasks
@Strohgelaender Strohgelaender force-pushed the bugfix/bamboo-long-feedback branch from 36621fb to acff214 Compare July 10, 2023 08:10
@Strohgelaender Strohgelaender requested review from b-fein and krusche and removed request for b-fein July 10, 2023 08:10
@krusche krusche merged commit cc0e5b7 into main Jul 18, 2023
@krusche krusche deleted the bugfix/bamboo-long-feedback branch July 18, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-fein b-fein b-fein approved these changes

@krusche krusche Awaiting requested review from krusche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Strohgelaender @b-fein @krusche