-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix obsolete Nerd Font icons #830
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #830 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 45 45
Lines 4280 4280
=======================================
Hits 3739 3739
Misses 541 541
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you help to add some notice under FAQ about this change?
Where is the FAQ? Should I add it to the README section? (edited) |
@zwpaper I've added a FAQ. I'm not a native English speaker so please let me know if you see anything strange in the FAQs. |
hi @nix6839, I have one more question, Are the pre-patched fonts updated to this latest v2.3.x version? https://github.com/ryanoasis/nerd-fonts#patched-fonts looks like the Hack Nerd I was using did not show the expected icons |
@zwpaper If you look at https://washnix.com/hack-nerd/, it is patched correctly. The source code of the page: https://github.com/nix6839/hack-nerd/blob/main/index.html |
hi @nix6839, I double check for the icons, it works like a charm, will merge after CI passed, thanks again! |
Thank you for your hard work. |
Replace the old code point with the new code point.
See: https://github.com/ryanoasis/nerd-fonts/releases/tag/v2.3.3
TODO
cargo fmt