DM-42797: Fix templates for data query typo and chain collection ordering issue #39
Conversation
There was a problem hiding this comment.
I know the commits in cm_prod are the wild west, but it'd good to get in the habit of the DM commit style so that you don't even think about it when your committing to a DM repo: https://developer.lsst.io/work/flow.html#git-commit-message-best-practices
Fix template for... would have been better. I would have worded this something like:
Override finalJob and remove step8
because step8 is run outside of cm_tools
| priority: 1000 | ||
|
|
||
| executionButler: |
There was a problem hiding this comment.
Did this executionButler section end up being needed?
There was a problem hiding this comment.
It was a last-ditch effort to see if the issues with BPS making extra collection chains would go away if we put this back in. It didn't work; Michelle helped us with another solution-- trying to track that down now.
There was a problem hiding this comment.
Looks like the bit on Jen's commit is what we need. I'll have to clean up the PR and make sure this gets in before we start the next weekly.
examples/common_setup.sh
Outdated
| # Use this for runs you want in the butler in the traditional place | ||
| #root_coll="HSC/runs/RC2" | ||
| root_coll="HSC/runs/RC2" |
There was a problem hiding this comment.
You probably want to leave the default as the generic test root_coll of as "u/${USER}/cm".
There was a problem hiding this comment.
Oop, I didn't think this would get pulled in. I can clean up the pull request later today or before this gets merged, thanks.
eigerx
changed the title
eigerx
force-pushed
the
tickets/DM-42797
branch
from
1920bf9 to
2cd94b9
Compare
There was a typo, an extra " in the data query that we fixed and the output chain collection was generating a user collection unnecessarily to fix this we set the output collection to null and that worked.