Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43665: Change LFA object URL from https to s3. #6

Merged
merged 1 commit into from
Apr 3, 2024
+2 −0
Merged

DM-43665: Change LFA object URL from https to s3. #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/lsst/consdb/hinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,8 @@ async def main() -> None:
message = (await deserializer.deserialize(msg.value))["message"]
logging.debug(f"Received message {message}")
url = message["url"]
# Replace local HTTP access URL with generic S3 access URL.
url = re.sub(r"https://s3\.\w+\.lsst\.org/", "s3://", url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need the word host in there .. now you make S3://rubinobs-lfa-cp/ATHeaderService/header/2024/04/01/ATHeaderService_header_AT_O_20240401_000286.yaml how does ResourcePath know its got a host or not ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The host comes from the S3_ENDPOINT_URL environment variable.

if bucket_prefix:
url = re.sub(r"s3://", "s3://" + bucket_prefix, url)
resource = ResourcePath(url)
Expand Down
Loading