Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42411: Update 8c57494cabcc.py to support offline mode. #33

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

andy-slac
Copy link
Collaborator

As this script depends on schema reflection, it needs a workaround for using non-mock connection for reflection.

Checklist

  • added documentation for a new migration script

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1edff52) 54.36% compared to head (d8b3a94) 54.35%.

Files Patch % Lines
...ython/lsst/daf/butler_migrate/butler_attributes.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   54.36%   54.35%   -0.01%     
==========================================
  Files          33       33              
  Lines        1146     1148       +2     
  Branches      255      255              
==========================================
+ Hits          623      624       +1     
- Misses        489      490       +1     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

As this script depends on schema reflection, it needs a workaround for
using non-mock connection for reflection.
@andy-slac
Copy link
Collaborator Author

I am going to merge this branch so that this is not forgotten. Ticket is still open, I'll close it after actual migration happens.

@andy-slac andy-slac merged commit 6c2d5d5 into main Feb 21, 2024
8 of 10 checks passed
@andy-slac andy-slac deleted the tickets/DM-42411 branch February 21, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant