DM-43357: Assorted fixes/improvements for fitting and plotting #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
approved these changes
May 9, 2024
| """RuntimeError for when there is no data to fit.""" | ||
|
|
||
| @classmethod | ||
| @abstractmethod |
There was a problem hiding this comment.
I don't think you want this to have @abstractmethod.
| @@ -473,6 +473,12 @@ def fit( | |||
| if len(flux_total) != 1: | |||
| raise RuntimeError(f"len({flux_total=}) != 1; PSF model is badly-formed") | |||
| flux_total = flux_total[0] | |||
| gaussians_linear = None | |||
| if config.fit_linear_init: | |||
| flux_total.fixed = False | |||
There was a problem hiding this comment.
Is there a point to setting this, then changing it at line 480? Is flux_total actually a parameter of model_source that is affecting the next line? If so, please add a comment explaining.
There was a problem hiding this comment.
Yes, this is the easiest way to make the next line work correctly, and I added a note about that.
| @@ -506,6 +512,7 @@ def fit( | |||
| # dummy size for first iteration | |||
| size, size_new = 0, 0 | |||
| fitInputs = FitInputsDummy() | |||
| catexp_get_psf_image = catexp.get_psf_image | |||
There was a problem hiding this comment.
What are you getting out of moving this here?
There was a problem hiding this comment.
It's a probably-irrelevant micro-optimization. I could do the same with setting modeller=self.modeller to avoid more attribute retrievals in the for loop, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are various things that came up during testing. There's no particular theme to the changes.