Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C] Remove cors header from default.conf #2

Merged
merged 1 commit into from
Jun 15, 2021
Merged

[C] Remove cors header from default.conf #2

merged 1 commit into from
Jun 15, 2021

Conversation

blnkt
Copy link

@blnkt blnkt commented Jun 15, 2021

Craft 3 already sets this header, so setting it again was throwing a "multiple headers" error in the browser: craftcms/cms#4830

[C] Remove cors header from default.conf
9d26183 
Craft 3 already sets this header, so setting it again was throwing a "multiple headers" error in the browser: craftcms/cms#4830
@blnkt blnkt requested a review from ericdrosas87 June 15, 2021 17:37
ericdrosas87
ericdrosas87 approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@ericdrosas87 ericdrosas87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to keep this line in mind when deploying the dockerized client - I'll need to define a custom network between the UI and backend containers

@blnkt blnkt merged commit 17d8156 into master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdrosas87 ericdrosas87 ericdrosas87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blnkt @ericdrosas87