DM-45131: Use LsstLogAdapter for logger and document it as an option #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
commented
Jul 5, 2024
| import lsst.log as lsstLog | ||
|
|
||
| log = lsstLog.Log.getLogger(__name__) | ||
| log = lsst.utils.logging.getLogger(__name__) | ||
|
|
||
| if verbose: |
There was a problem hiding this comment.
I retained the logic where verbose is only used if log is None. That might not be intentional but it is what was implemented before. The logger is reset if verbose is not set because (1) by default it's WARNING and (2) otherwise calling this with verbose True and then False would leave the trace logger set.
fred3m
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
LGTM. TBH I'm not sure we even need to pass log as an argument anymore. It thinks it's an artifact of the code many moons ago, long before I was on the project. So feel free to completely strip out this logic entirely if you want, or just leave it as is to minimize the work needed to finish DM-45131.
Also modify the documentation to note that a default logger is created rather than disabling logging and that verbose only affects that default logger.
mwittgen
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.