Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-46933: Remove references to STREAK mask #264

Merged
merged 2 commits into from
Oct 20, 2024
Merged

DM-46933: Remove references to STREAK mask #264

merged 2 commits into from
Oct 20, 2024

Conversation

TallJimbo
Copy link
Member

See DM-45980 for details.

parejkoj
parejkoj reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I wrote this, I think it should have someone else review it (nobody had reviewed it on the original PR).

@JeremyMcCormick JeremyMcCormick changed the title DM-46933: remove references to STREAK mask DM-46933: Remove references to STREAK mask Oct 18, 2024
@JeremyMcCormick
Copy link
Collaborator

JeremyMcCormick commented Oct 18, 2024 •
edited
Loading

Nitpick: Please author your commit messages to follow DM common standards:

aa84e42

e.g. this should be something like "Remove streak flag fields ..."

@JeremyMcCormick JeremyMcCormick self-requested a review October 18, 2024 22:55
JeremyMcCormick
JeremyMcCormick requested changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

#264 (comment)

@TallJimbo
Copy link
Member Author

Commit has been reworded.

@TallJimbo TallJimbo merged commit 64a4877 into main Oct 20, 2024
9 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-46933 branch October 20, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj left review comments

@JeremyMcCormick JeremyMcCormick JeremyMcCormick approved these changes

@leeskelvin leeskelvin leeskelvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TallJimbo @JeremyMcCormick @parejkoj @leeskelvin