Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47403: Fix problems in GitHub build workflow #276

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented Nov 5, 2024

Fix issues in the build workflow:

  1. Use the standard workflow trigger instead of on: push
  2. Add fetch-depth: 0 to checkout
  3. Build and push Docker images on all triggers, including for user branches and merges to main
  4. Update the tap-schema/build script so it creates Docker images with the proper names for all cases (tags, branches & PRs)

Miscellaneous changes:

  1. Remove a commented-out column from imsim
  2. Add lsst versions file and config.log to .gitignore

@JeremyMcCormick JeremyMcCormick requested a review from timj November 5, 2024 20:46
@JeremyMcCormick JeremyMcCormick marked this pull request as draft November 5, 2024 20:48
@JeremyMcCormick JeremyMcCormick force-pushed the tickets/DM-47403 branch 4 times, most recently from ed5a872 to d6a4fa5 Compare November 5, 2024 21:24
@JeremyMcCormick JeremyMcCormick marked this pull request as ready for review November 5, 2024 21:26
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the version code now works

lsst-sdm-schemas==28.2024.4403 (from file:///home/runner/work/sdm_schemas/sdm_schemas)

For PRs, the GITHUB_HEAD_REF variable needs to be used in order to get
the branch name.
@JeremyMcCormick JeremyMcCormick merged commit 8aad214 into main Nov 5, 2024
9 checks passed
@JeremyMcCormick JeremyMcCormick deleted the tickets/DM-47403 branch November 5, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants