Delete irrlichttypes_bloated.h

[wrrrzr]

This PR is Ready for Review.

[lhofhansl]

Compiles fine and looks good.

[appgurueu]

Looks reasonable.

[appgurueu]

Sorry, I think I have to go back on that after running Include What You Use as suggested by Desour. My review is not comprehensive. I've attached the full output: iwyu.txt. Look at all the files this PR touches, and check whether IWYU suggests that you add some headers, and check whether it is right (because it can still make mistakes).

In general (I think Desour also suggested this in the past), you should probably use IWYU as a decent starting point when working on such PRs.

[sfan5]

👎 IMO there's no value in "optimizing" these five header includes. Vectors, AABB and SColor are reasonably common.
Also the using namespace irr; ought to stay centralized instead of duplicating it in some files.

[lhofhansl]

Fair enough @appgurueu and @sfan5

[wrrrzr]

👎 IMO there's no value in "optimizing" these five header includes. Vectors, AABB and SColor are reasonably common. Also the using namespace irr; ought to stay centralized instead of duplicating it in some files.

Where should "using namespace irr;" be then?

[Desour]

Sorry, I think I have to go back on that after running Include What You Use as suggested by Desour. My review is not comprehensive. I've attached the full output: iwyu.txt. Look at all the files this PR touches, and check whether IWYU suggests that you add some headers, and check whether it is right (because it can still make mistakes).

In general (I think Desour also suggested this in the past), you should probably use IWYU as a decent starting point when working on such PRs.

Sorry if there has been confusion, but I did not suggest to base such PRs on IWYU output.
Relying to some extent on recursive includes is not that big of an issue imo, as long as the recursive includes are not in a library header (and unspecified). It can cause breakages if you remove an include in one of our headers, but it's trivial to fix it then, so 🤷.
And IWYU suggests to add too much if the appropriate IWYU pragmas are missing (e.g. export of vector3d.h in irr_v3d.h).

👎 IMO there's no value in "optimizing" these five header includes. Vectors, AABB and SColor are reasonably common. Also the using namespace irr; ought to stay centralized instead of duplicating it in some files.

v2d and v3d are probably very common, but aabb and color?

We already have many using namespace irr; declarations.

Where should "using namespace irr;" be then?

It's in irrlichttypes.h.

Anyway, if we end up keeping this kind of prelude header, warnings need to be suppressed. https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md

[sfan5]

v2d and v3d are probably very common, but aabb and color?

% rg -l 'v[23][su](16|32)' src -g '*.h' | wc -l
108
% rg -l SColor src -g '*.h' | wc -l
54
% rg -l aabb3f src -g '*.h' | wc -l
25

I guess aabb3f could be removed.

We already have many using namespace irr; declarations.

Indeed, and we shouldn't have them. I bet most are redundant anyway.
Currently we have a bunch of custom defines in irrlichttypes.h and to make them consistently available no Luanti code should be including irrTypes.h directly.