Skip to content

Commit

Permalink
add sideEffects false in package jsons (#335)
Browse files Browse the repository at this point in the history
  • Loading branch information
ericfennis authored May 24, 2021
1 parent 91d0a12 commit 4e53232
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 2 additions & 0 deletions packages/lucide-preact/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
"module": "dist/esm/lucide-preact.js",
"unpkg": "dist/umd/lucide-preact.min.js",
"typings": "dist/lucide-preact.d.ts",
"sideEffects": false,

"scripts": {
"build": "yarn clean && yarn build:icons && yarn build:es && yarn build:types && yarn build:bundles",
"clean": "rm -rf dist && rm -rf stats && rm -rf ./src/icons/*.js",
Expand Down
1 change: 1 addition & 0 deletions packages/lucide-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"module": "dist/esm/lucide-react.js",
"unpkg": "dist/umd/lucide-react.min.js",
"typings": "dist/lucide-react.d.ts",
"sideEffects": false,
"scripts": {
"build": "yarn clean && yarn build:icons && yarn build:es && yarn build:types && yarn build:bundles",
"clean": "rm -rf dist && rm -rf stats && rm -rf ./src/icons/*.js",
Expand Down
1 change: 1 addition & 0 deletions packages/lucide-vue-next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"module": "dist/esm/lucide-vue-next.js",
"unpkg": "dist/umd/lucide-vue-next.min.js",
"typings": "dist/lucide-vue-next.d.ts",
"sideEffects": false,
"scripts": {
"build": "yarn clean && yarn build:icons && yarn build:es && yarn build:types && yarn build:bundles",
"clean": "rm -rf dist && rm -rf ./src/icons/*.js",
Expand Down
7 changes: 3 additions & 4 deletions packages/lucide-vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
"main:umd": "dist/umd/lucide-vue.js",
"module": "dist/esm/lucide-vue.js",
"unpkg": "dist/umd/lucide-vue.min.js",
"dependencies": {
"vue": "^2.6.12"
},
"sideEffects": false,
"scripts": {
"build": "yarn clean && yarn build:icons && yarn build:es && yarn build:bundles",
"clean": "rm -rf dist && rm -rf stats && rm -rf ./src/icons/*.js",
Expand All @@ -33,7 +31,8 @@
"@vue/test-utils": "^1.1.2",
"jest-serializer-vue": "^2.0.2",
"vue-jest": "^3.0.7",
"vue-template-compiler": "^2.6.12"
"vue-template-compiler": "^2.6.12",
"vue": "^2.6.12"
},
"peerDependencies": {
"vue": "^2.6.12"
Expand Down

0 comments on commit 4e53232

Please sign in to comment.