Make sure we apply all classes to the lucide icons #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
⚛️ react package
github-actions
bot
added
📦 dependencies
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
realguse
pushed a commit
to realguse/lucide
that referenced
this pull request
Dec 25, 2024
* Make sure all classes are applied for all packages * Add class test to angular component * Adjust lucide-static tests * update snapshot * Fix types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1681
What is the purpose of this pull request?
Description
Make sure we have consistency across all our packages when we apply classes to icon components. Some packages like
lucide-reactandlucide-preactremoved the default classNames. What makes it hard to apply global styling on these icons is if you want to have a customclassName.I've added tests to make sure we apply all the classes.
Before Submitting