Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add expand and shrink icons #211

Merged
merged 4 commits into from
May 16, 2021
Merged

add expand and shrink icons #211

merged 4 commits into from
May 16, 2021

Conversation

mittalyashu
Copy link
Member

@mittalyashu mittalyashu commented Feb 5, 2021 •
edited
Loading

Preview
CleanShot 2021-05-16 at 13 04 04@2x

@ericfennis
Copy link
Member

ericfennis commented Feb 6, 2021 •
edited
Loading

Nice icons!
The left-right and top-down already exists. They called move-vertical and move-horizontal.

https://lucide.netlify.app/?search=Move

@ericfennis ericfennis added the 🎨 icon About new icons label Feb 6, 2021
@ericfennis
Copy link
Member

@mittalyashu Can you try to match expand and shrink icons with the maximize-2 and the minimize-2 icons? So the design looks more consistent.

@vercel
Copy link

vercel bot commented Apr 30, 2021

@ericfennis is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lucide/lucide/HubhJsYPQhRFARb7b7pZD1w3JoKL
✅ Preview: https://lucide-git-fork-mittalyashu-icon-arrow-s-lucide.vercel.app

@mittalyashu
Copy link
Member Author

LGTM

@mittalyashu
Copy link
Member Author

@ericfennis Any other changes this PR require?

@moeenio
Copy link
Contributor

moeenio commented May 15, 2021

@mittalyashu Can you try to match expand and shrink icons with the maximize-2 and the minimize-2 icons? So the design looks more consistent.

@mittalyashu
Copy link
Member Author

LGTM

@moeenio
Copy link
Contributor

moeenio commented May 16, 2021

Please update the preview, if you didn't

@ericfennis ericfennis merged commit 97c03c7 into lucide-icons:master May 16, 2021
@moeenio moeenio changed the title add arrow's icons add expand and shrink icons May 16, 2021
@mittalyashu
Copy link
Member Author

@locness3 the preview is already updated.

realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
@mittalyashu @ericfennis
add arrow's icons (lucide-icons#211)
7fb4335 
* add arrow's icons

* Delete top-bottom.svg

* Delete left-right.svg

* fix: icon padding 2px border

Co-authored-by: Eric Fennis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfennis ericfennis ericfennis approved these changes

Assignees
No one assigned
Labels
🎨 icon About new icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mittalyashu @ericfennis @moeenio