Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add circle-check-2 icon #237

Merged
merged 1 commit into from
May 18, 2021

Conversation

mittalyashu
Copy link
Member

zoom 100%
CleanShot 2021-02-25 at 16 07 32@2x CleanShot 2021-02-25 at 16 07 40@2x

@vercel
Copy link

vercel bot commented Feb 25, 2021

@mittalyashu is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

@ericfennis
Copy link
Member

ericfennis commented Feb 26, 2021

hmm looks not like the one you posted in discord. I think the check can bigger. on 100% scale the icons looks too small.
Your post in discord:
image

@vercel
Copy link

vercel bot commented Mar 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lucide/lucide/3beL4FhjEXQQVzbGnP11UckgcnYE
✅ Preview: https://lucide-git-fork-mittalyashu-icon-circle-check-2-lucide.vercel.app

@mittalyashu
Copy link
Member Author

@ericfennis the reason I made the check smaller in size, as it looks like it will be touching the circle at 100% view.

Also, we try increasing the stroke-width it will look even more weird.

@github-actions
Copy link

github-actions bot commented May 5, 2021

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 5, 2021
Copy link
Contributor

@moeenio moeenio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except it should be check-circle-2.

@mittalyashu
Copy link
Member Author

mittalyashu commented May 16, 2021

@locness3 Isn't the file name is already that circle-check-2?

@moeenio
Copy link
Contributor

moeenio commented May 16, 2021

It should be the other way around. check-circle-2, not circle-check-2

@github-actions github-actions bot removed the Stale label May 17, 2021
@ericfennis
Copy link
Member

@locness3 It's check-circle-2 !

@ericfennis ericfennis merged commit 1e9a09e into lucide-icons:master May 18, 2021
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants