-
-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add headphone-off svg & json in icon folder #2445
add headphone-off svg & json in icon folder #2445
Conversation
Added or changed iconsIcons as codeWorks for: const HeadphoneOffIcon = createLucideIcon('HeadphoneOff', [
["path",{"d":"M21 14h-1.343"}],
["path",{"d":"M9.128 3.47A9 9 0 0 1 21 12v3.343"}],
["path",{"d":"m2 2 20 20"}],
["path",{"d":"M20.414 20.414A2 2 0 0 1 19 21h-1a2 2 0 0 1-2-2v-3"}],
["path",{"d":"M3 14h3a2 2 0 0 1 2 2v3a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2v-7a9 9 0 0 1 2.636-6.364"}]
]) |
Hi @Need-an-AwP, Please split the path up into its separate parts, as some renderers end up with funky paths if they are merged. The icon is mostly well designed, but the bottom parts need a larger gap between the diagonal line and the headphone (2px to be precise). |
@karsa-mistmere |
adjust the gap this time and seems like some automatic process went wrong |
@karsa-mistmere |
Again, it's not the segments, it's just that we do not allow combined paths, as they can be rendered funky in Figma for example. Every path should be a single path made up of any number and type of segments between two points, your original file had only two paths, one for the line, one for everything else. While the original headphone shape is a single line, this one is made up of four distinct paths. |
@karsa-mistmere i rewrote each path, is this change ok?😥 |
Not quite, but it's close:
|
Lucide studio has a tidy button that does that for you. |
It won't close the gaps that are too large though. |
@karsa-mistmere is this gap enough |
You can check via the icon x-rays if the gap is ideal, these lines should touch but not intersect: I see you're using Figma, my modus operandi for creating perfect gaps is as follows:
Ta-da! 🥳 |
thank u for the tutorial with a lot details, i used the method u provide redraw the icon and adjusted my svg code |
* add headphone-off svg & json in icon folder * edit contributor in json & adjust icon * adjust icon * contributors changed * icon adjust * adjust path * detail adjustment * Apply suggestions from code review Co-authored-by: Karsa <[email protected]> * delete files of categories in headphone-off's json * prettier format json --------- Co-authored-by: Karsa <[email protected]>
What is the purpose of this pull request?
Description
this headphone-off icon is based on headphone icon and mic-off icon
I followed the design style of the mic-off icon and modified the headphone icon with figma
i cannot run any build, optimize or test script on my pc, i always have different errors on running them
this change is committed with --no-verify
Icon use case
just like mic-off icon, headphone-off icon can be use to show audio output muted
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting