Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packages sections #402

Merged
merged 35 commits into from
Oct 1, 2021

Conversation

ericfennis
Copy link
Member

@ericfennis ericfennis commented Sep 20, 2021

I added a packages section, you can navigate via the packages link in the nav.
And worked on the first version of the docs section, but that need to be completed with a sidebar for links and some nice navigation. The markdown part is completely done.

Closes #336

Preview:

image

@ericfennis ericfennis added 📖 documentation Improvements or additions to documentation 🌍 site Has to do something with the Lucide website labels Sep 20, 2021
@moeenio
Copy link
Contributor

moeenio commented Sep 22, 2021

I'd also put this stuff somewhere on the homepage. Like use it with : React / Vue / ...

@moeenio
Copy link
Contributor

moeenio commented Sep 22, 2021

Or just a more prominent link to this page.

@ericfennis
Copy link
Member Author

Yeah good idea, small section with all the supported frameworks.

@ericfennis
Copy link
Member Author

ericfennis commented Sep 26, 2021

Added small section to the homepage.

@locness3 Let me know what you think!
image

@moeenio
Copy link
Contributor

moeenio commented Sep 26, 2021

Nice, maybe a bit smaller.

@ericfennis
Copy link
Member Author

@locness3 Resized them!

@moeenio
Copy link
Contributor

moeenio commented Sep 26, 2021

Looks good! Final suggestions :

  • make the "available for" text link to the packages page
  • add a line break between the "available for" text and the icons, on mobile but maybe also on desktoo

@ericfennis
Copy link
Member Author

@locness3 got ya!

@ericfennis
Copy link
Member Author

@locness3 I think this is it, can you check if it is right?

@moeenio
Copy link
Contributor

moeenio commented Sep 28, 2021

Perfect.

@moeenio
Copy link
Contributor

moeenio commented Sep 28, 2021

Oh, shouldn't the downloads/version badges on the packages page link to something?

@ericfennis
Copy link
Member Author

I added them @locness3 tnx for noticing.
If you find more thing let me know, I will fix it in an other PR

@ericfennis ericfennis merged commit 6f7c94e into lucide-icons:master Oct 1, 2021
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
* Add markdown support

* Fix a lot of issues

* Add core components

* Add codeblocks

* fix codeblocks

* Add More components

* add links

* Fix loading docs

* Fix docs

* Fix empty lines

* small Fix

* Add heading provider

* created menu

* remove borderline

* Add mobilemenu component

* add next env

* update code style

* generate heading element positions

* Add package pages

* add fetch packages

* Add lucide logo

* Add icons and adjust description

* improve some things

* fix types

* Fix logo types

* fix types

* Add logo's

* update packages docs

* resize icons

* small changes

* update packages links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation 🌍 site Has to do something with the Lucide website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote the library packages on the website
2 participants