Skip to content
This repository was archived by the owner on Jul 12, 2019. It is now read-only.

Add mobile and tablet styles #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sch
Copy link

@sch sch commented Oct 14, 2018

I found myself wanting to read the docs on my phone, but I was having a hard time! This PR makes minimal changes to the existing styles and as few changes as possible to the existing markup to add responsive views into the guides.

Screenshots

Mobile:

Tablet:

Oddities

Some other things that should perhaps be addressed as a part of this feature:

  • Should the guide navigation be collapsed in a menu on mobile? Heroku's docs do a nice job of this. Depends on your appetite for scrolling.
  • Should the top navigation have some kind of menu? Stripe's thing is 👌. The search is probably the main offender here in my implementation.
  • Anything you have in mind around the homepage?

@jwoertink
Copy link
Member

I like this, and think it's pretty necessary. @sch, do you still have time to work on this? If so, can you rebase from master to pull in all the latest stuff?

Closes luckyframework#43

This commit makes minimal changes to the existing styles and as few
changes as possible to the existing markup to add responsive views into
the guides.
@sch sch force-pushed the responsive-design branch from 1accadb to 7c0c46c Compare March 9, 2019 02:45
@sch
Copy link
Author

sch commented Mar 9, 2019

👍Just gave it a rebase. There are a few odd ducks from the new changes:

  • inline code styles wrap badly
  • the header is still cramped

I'll take a shot at improving those this weekend.

@jwoertink
Copy link
Member

The code blocks probably shouldn't wrap. Maybe just give them an overflow? Thanks for hopping back on this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants