Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lr_scheduler options #111

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Add lr_scheduler options #111

merged 3 commits into from
Dec 22, 2023

Conversation

EnricoTrizio
Copy link
Collaborator

Description

Added the possibility to use torch learning rate scheduler.
They should be passed using the options in the CV models

This closes #96

Status

  • Ready to go

@codecov Codecov
Copy link

codecov bot commented Dec 22, 2023 •
edited
Loading

Codecov Report

Merging #111 (28c2e1b) into main (8c20185) will increase coverage by 0.21%.
Report is 24 commits behind head on main.
The diff coverage is 55.55%.

Additional details and impacted files

andrrizzi
andrrizzi approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@andrrizzi andrrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'd suggest not to cache the self._lr_scheduler_name attribute internally.

mlcolvar/cvs/cv.py Outdated Show resolved Hide resolved
mlcolvar/cvs/cv.py Outdated Show resolved Hide resolved
@luigibonati luigibonati merged commit fd7bce8 into main Dec 22, 2023
12 checks passed
@luigibonati luigibonati deleted the lr_scheduler branch December 22, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigibonati luigibonati luigibonati left review comments

@andrrizzi andrrizzi andrrizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add lr_scheduler options in BaseCV.configure_optimizers
3 participants
@EnricoTrizio @andrrizzi @luigibonati